misc: util: Allow conditional macros to depend on whether a property in DTS exists #14788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
changed the title
benpicco
changed the title
Codecov Report
@@ Coverage Diff @@
## master #14788 +/- ##
=======================================
Coverage 52.51% 52.51%
=======================================
Files 309 309
Lines 45048 45048
Branches 10419 10419
=======================================
Hits 23656 23656
Misses 16584 16584
Partials 4808 4808
Continue to review full report at Codecov.
|
Instead of #define DT_ATMEL_SAM0_UART_41012000_IRQ_0 54 make the script output #define DT_ATMEL_SAM0_UART_41012000_IRQ_0 (54) This allows for some advanced macro magic. Also make sure not to enclose strings in parentheses as this will interfere with some other macro magic conjured by nrf52. Signed-off-by: Benjamin Valentin <[email protected]>
Add a helper function that can be used together with COND_CODE_1. If the macro parameter resolves to a real (parenthesized) variable, this macro resolves to '1', if it resolves to a macro that can not be resolved to a variable, it resolves to '0'. Signed-off-by: Benjamin Valentin <[email protected]> Signed-off-by: Derek Hageman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an idea from C Preprocessor tricks, tips, and idioms to allow for conditional compilation of code depending on whether a parametrically assembled macro resolves to a real defined macro (from DTS) or not.
E.g. newer Atmel sam0 parts have 4 interrupts associated with a SERCOM peripheral while older ones only had one. The Interrupt setup code is assembled in a macro already to prevent copy & paste for all SERCOMs. This allows to use a nested macro for the actual interrupt enablement. If the Interrupt exists, the corresponding setup code is inserted. If it doesn't exist, the macro resolves to nothing.
@Sizurka expressed interest in this too - #14685 (review)