Skip to content

Conversation

@pabigot
Copy link
Contributor

@pabigot pabigot commented Feb 7, 2019

Relates to #13076 and #13143. This, by the way, is exactly why something like:

   if ((flags & FOO_MASK) == FOO_VALUE) { }

is superior to:

   if (flags & FOO_VALUE) { }

Interrupts default to trigger on level for historical reasons, so use of
GPIO_INT_LEVEL` as a mask results in a zero value.  Use a mask macro to
isolate the trigger configuration.

Signed-off-by: Peter A. Bigot <[email protected]>
Interrupts default to trigger on level for historical reasons, so use of
GPIO_INT_LEVEL` as a mask results in a zero value.  Use a mask macro to
isolate the trigger configuration.

Signed-off-by: Peter A. Bigot <[email protected]>
@galak galak merged commit d080d1d into zephyrproject-rtos:master Feb 8, 2019
@pabigot pabigot deleted the pr/20190207a branch September 8, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants