gpio: gpio_sch: fix check for interrupt trigger #13143
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controller does not support trigger. However, the check for this condition was incorrectly (as GPIO_INT_LEVEL is 0). So fix it. Signed-off-by: Daniel Leung <[email protected]>
pabigot
approved these changes
Feb 7, 2019
Contributor
pabigot
left a comment
pabigot
left a comment
There was a problem hiding this comment.
I'd have gone with
if ((flags & GPIO_INT) && !(flags & GPIO_INT_EDGE))
rather than nested if, but yeah, this will probably work better.
Codecov Report
@@ Coverage Diff @@
## master #13143 +/- ##
=======================================
Coverage 48.73% 48.73%
=======================================
Files 315 315
Lines 46538 46538
Branches 10743 10743
=======================================
Hits 22678 22678
Misses 19348 19348
Partials 4512 4512Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller does not support trigger. However, the check for
this condition was incorrectly (as GPIO_INT_LEVEL is 0). So fix
it.
Signed-off-by: Daniel Leung [email protected]