shell: Enable backends via Kconfig file #10379
Conversation
jakub-uC
force-pushed
the
shell_fixing_Kconfig_dependencies
branch
from
8efaf14 to
b0a29f0
Compare
subsys/shell/Kconfig.backends
Outdated
There was a problem hiding this comment.
No quotes needed around the help texts (they become part of it if added).
subsys/shell/Kconfig.backends
Outdated
subsys/shell/Kconfig.backends
Outdated
There was a problem hiding this comment.
Nit: Could add a space after #
subsys/shell/Kconfig.backends
Outdated
There was a problem hiding this comment.
depends on is usually a better choice than select when visible symbols (symbols with prompts) are involved.
See #10212 (comment) for discussion. It involves the same symbol.
There was a problem hiding this comment.
About this, please note that #10190 got reopened due to this:
#10127 (comment)
#10127 (comment)
There was a problem hiding this comment.
Ah, sorry, had missed the ping in #10190.
Just default y if SHELL on SERIAL would be problematic if SHELL needs SERIAL, as it would still be possible for the user to turn off SERIAL with SHELL enabled in that case.
I won't block this for select-related issues at least.
Codecov Report
@@ Coverage Diff @@
## master #10379 +/- ##
==========================================
- Coverage 52.9% 52.83% -0.07%
==========================================
Files 210 210
Lines 25732 25732
Branches 5672 5672
==========================================
- Hits 13614 13596 -18
- Misses 9802 9821 +19
+ Partials 2316 2315 -1
Continue to review full report at Codecov.
|
Added functionality to enable active shell backends via Kconfig file. When there will be more backends implemented user will have an option to select only required ones. It is no longer needed to select SERIAL in prj.conf. Fixes zephyrproject-rtos#10190 Signed-off-by: Jakub Rzeszutko <[email protected]>
jakub-uC
force-pushed
the
shell_fixing_Kconfig_dependencies
branch
from
b0a29f0 to
83f6e28
Compare
7 participants
Added functionality to enable active shell backends via Kconfig
file. When there will be more backends implemented user will
have an option to select only required ones.
It is no longer needed to select SERIAL in prj.conf.
Fixes #10190
Signed-off-by: Jakub Rzeszutko [email protected]