Cannot use new shell with native_posix

[jukkar]

I am seeing this when compiling new net-shell for native_posix and uart.

../zephyr/subsys/shell/shell_uart.c:29:36: error: ‘CONFIG_UART_CONSOLE_ON_DEV_NAME’ undeclared (first use in this function); did you mean ‘CONFIG_ETH_NATIVE_POSIX_DEV_NAME’?
  sh_uart->dev = device_get_binding(CONFIG_UART_CONSOLE_ON_DEV_NAME);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                    CONFIG_ETH_NATIVE_POSIX_DEV_NAME
../zephyr/subsys/shell/shell_uart.c:29:36: note: each undeclared identifier is reported only once for each function it appears in

This prevents merging of #9825 because sanitychecker fails.

[aescolar]

there is no UART in native_posix..

[pfalcon]

It's the same issue as in #5947 (which was skipped, unresolved).

And of course, the baseline problem is that shell should not deal with uart, shell should deal with console, and console should deal with uart. As in many places in Zephyr, we lack proper layering.

[aescolar]

I will try to add today or so a UART for native_posix.

[nordic-krch]

@pfalcon console has limitations: single byte, synchronous api, single instance. I agree that we should have shell console backend but i would also like to see improvements in the console.

[aescolar]

@nordic-krch , @jarz-nordic : Why is the new shell depending on a CONSOLE config option if it is not using it?

[pfalcon]

@nordic-krch :

i would also like to see improvements in the console.

You probably should say which console you mean, as we have many "consoles" in Zephyr. If you mean subsys/console/ , yep, it needs further improvements based on the different usecases. RFCs and patches are welcome. Note that I foresee it going into the POSIX direction re: API.

[aescolar]

I think we need 2 new issues linked to this one:

• The new shell (CONSOLE_SHELL) can only be compiled on boards with SERIAL but it does not set the dependency in its Kconfig options
• The new shell uses CONSOLE kconfig options, even though it does not use CONSOLE.

@jarz-nordic : Do you agree? will you create the issues or prefer me to do it for you?

[jakub-uC]

Hi,
In my opinion current UART backend implementation for shell must be changed to get rid off CONSOLE dependencies. It should be looking for SERIAL instead.
CONSOLE could be simply one more shell backend.