-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Fix undefined reference to `__log_current_const_data_get' when using LOG_MODULE_DECLARE #10045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined reference to `__log_current_const_data_get' when using LOG_MODULE_DECLARE #10045
Conversation
carlescufi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
mbolivar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, tested locally, confirmed test_module.c compiles
|
@nordic-krch seems some tests are running out of RAM with the patch, can you take a look and blacklist/whitelist/modify as required? |
b546871 to
543f693
Compare
Codecov Report
@@ Coverage Diff @@
## master #10045 +/- ##
=======================================
Coverage 52.96% 52.96%
=======================================
Files 214 214
Lines 26156 26156
Branches 5636 5636
=======================================
Hits 13853 13853
Misses 10030 10030
Partials 2273 2273Continue to review full report at Codecov.
|
Fix compilation failure when LOG_MODULE_DECLARE is used. Signed-off-by: Krzysztof Chruscinski <[email protected]>
543f693 to
652f737
Compare
|
@carlescufi its not ram size issue, it looks more like a compiler issue (https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/22615/5/console):
There is plenty of ram but it seems like offset is limited to 32k. I've added altera_max10 and qemu_nios2 to platform_exlude list. Unless somebody knows how to fix it. |
652f737 to
3357f9f
Compare
Extending log_core test suite to test LOG_MODULE_DECLARE() macro. Signed-off-by: Krzysztof Chruscinski <[email protected]>
3357f9f to
332e303
Compare
Can you open a bug about this so we do not lose track of it? |
Fixing compilation failure when LOG_MODULE_DECLARE() is used. Added test to cover usage of that macro.
One thing to note. With current scheme (LOG_MODULE_DECLARE/LOG_MODULE_REGISTER taking module name) it is forbidden to use LOG_MODULE_DECLARE() in headers thus logging in static inline function in header is impossible. That is because both macros creates static inline function with the same name: __log_current_dynamic_data_get().
Fixes #10026