Skip to content

LPC GPIO hal support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2019
Merged

LPC GPIO hal support #11

merged 1 commit into from
Sep 12, 2019

Conversation

@agansari
Copy link
Contributor

@agansari agansari commented Sep 11, 2019 •
edited
Loading

@agansari
Copy link
Contributor Author

agansari commented Sep 11, 2019

@MaureenHelm @galak can't add reviewers or tags on this pull

@galak galak requested a review from MaureenHelm September 11, 2019 11:22
@galak
Copy link
Contributor

galak commented Sep 11, 2019

@MaureenHelm @galak can't add reviewers or tags on this pull

Added you as a collaborator so in the future you can.

@agansari
Copy link
Contributor Author

agansari commented Sep 11, 2019 •
edited
Loading

Added you as a collaborator so in the future you can.

Thanks @galak !

@galak galak mentioned this pull request Sep 11, 2019
Closed
galak
galak requested changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like the version of mcux/devices/LPC54114/fsl_pint.{c,h} aren't from SDK-2.6.0 release. (Seeing version Version 2.1.3 in the SDK-2.6.0). Please update/re-sync that.

@agansari
Copy link
Contributor Author

agansari commented Sep 11, 2019

So it looks like the version of mcux/devices/LPC54114/fsl_pint.{c,h} aren't from SDK-2.6.0 release. (Seeing version Version 2.1.3 in the SDK-2.6.0). Please update/re-sync that.

Yes I revisited the SDK releases an got the correct version up now.
But it seems SDKs have made nice and use the same fsl_pint.* files. I need to rework this as well.

@agansari
ext: lpc includes gpio related files
1b3058a 
When enabling GPIO on LPC family, sdk GPIO driver sources for GPIO,
PINT and input multiplexer devices are included.

Signed-off-by: Andrei Gansari <[email protected]>
@agansari
Copy link
Contributor Author

agansari commented Sep 12, 2019

@galak @MaureenHelm i removed the pint driver split, as LPC54xxx's SDK gpio driver was updated. No new SDK update was required.

@galak galak merged commit aca32aa into zephyrproject-rtos:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@galak galak galak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agansari @galak @MaureenHelm