Skip to content

Conversation

@RobertLowe
Copy link

🚀 🚀 🚀

What's the problem this PR addresses?
Add mention of prepare

...

How did you fix it?
Add mention of prepare

...

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I have verified that all automated PR checks pass.

Add mention of `prepare`
@arcanis
Copy link
Member

arcanis commented Aug 27, 2020

Hi, thanks for the contribution! However, we don't support prepare. Instead, as the documentation suggests, package artifacts should be created in the prepack script, which is called when cloning a repository. From the documentation:

Note that we don't support every single lifecycle script originally present in npm. This is a deliberate decision based on the observation that too many lifecycle scripts make it difficult to know which one to use in which circumstances, leading to confusion and mistakes. We are open to add the missing ones on a case-by-case basis if compelling use cases are provided.

@RobertLowe
Copy link
Author

RobertLowe commented Aug 27, 2020

@arcanis 1.x supports it yarnpkg/yarn#3004 ... prepack just seems to be a renamed prepare then no?

It also feels weird that the public docs would be for 2.x, when 1.x is what's stable on npm...?

@arcanis
Copy link
Member

arcanis commented Aug 27, 2020

No, prepack has always existed (cf the npm doc).

It also feels weird that the public docs would be for 2.x, when 1.x is what's stable on npm...?

Yarn 2 is the latest stable. We simply don't use npm to distribute it (or rather, it's more complex than this, cf our install docs).

@RobertLowe
Copy link
Author

I'll close this, hopefully it will help someone in the future

@RobertLowe RobertLowe closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants