Skip to content

Conversation

@RobertLowe
Copy link
Contributor

Straight forward, will let you install from a Git URL in your package.json

Cheers

PS: Dead code? : https://github.com/graphql-compose/graphql-compose-mongoose/blob/master/package.json#L10

@nodkz nodkz merged commit e22c490 into graphql-compose:master Aug 27, 2020
@nodkz
Copy link
Member

nodkz commented Aug 27, 2020

Wat?!... Amazing thing. I didn't know that such thing exists. Thanks!

@RobertLowe
Copy link
Contributor Author

@nodkz Yeah, it's not documented on yarn! But they added support for it. I made a PR, they should mention it! yarnpkg/berry#1770 most useful hook ever.

We should add it to all the repos?

Also, did you have a look at "module": "mjs/index.mjs", I don't think it's needed anymore?

@RobertLowe
Copy link
Contributor Author

Hah, after more research this only works with yarn < 2.x and npm they dropped support for it which is foolish.

@arcanis
Copy link

arcanis commented Aug 27, 2020

which is foolish

Always a pleasure.

Anyway, as I mentioned, the solution is to use prepack, which is portable.

@RobertLowe
Copy link
Contributor Author

Always a pleasure.

@arcanis gladly. In interesting of comparison I've tested a number of different configurations (no package.json using install/add, with package.json, with prepareorprepackin each) on a clean directories fornpm, yarn@1, yarn@2 and even pnpm`.

All in all, prepare worked the most reliably here. I'm not sure what's up. It doesn't compile properly with prepack. The best portability was among npm & yarn@1, the worst pnpm.

@github-actions
Copy link

🎉 This PR is included in version 8.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 9.0.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants