[service.projcontrol] 1.2.0 #868

fredrik-eriksson · 2018-07-12T17:12:41Z

Description

An addon for controling projectors connected via serial port. A more detailed description can be found on the project github page: https://github.com/fredrik-eriksson/kodi_projcontrol

It requires the pyserial module to work, and I've submitted that module in a separate PR. This addon can also optionally use flask to create a REST service to control the projector, however flask is not in the kodi repositories, and I have no will to submit and maintain it. As this addon is still usable (and hopefully even useful) even without the REST service I hope it's OK to include it anyway.

Checklist:

My code follows the add-on rules and piracy stance of this project.
I have read the CONTRIBUTING document
Each add-on submission should be a single commit with using the following style: [script.foo.bar] v1.0.0

Additional information :

Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
add-on development wiki page.
Kodi pydocs provide information about the Python API
PEP8 codingstyle which is considered best practise but not mandatory.
This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
Development questions can be asked in the add-on development section on the Kodi forum.

TravisBuddy · 2018-07-12T17:14:03Z

Travis Buddy

Hey Fredrik Eriksson,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on service.projcontrol
INFO: Created by Fredrik Eriksson
INFO: Addon id matches folder name
ERROR: Required addon script.module.pyserial not available in current repository.
INFO: This is a new addon
INFO: Image icon exists
ERROR: Icon.png should be solid. It has transparency.
INFO: icon dimensions are fine 256x256
INFO: You might want to add a fanart
WARN: Complex entry point. Check: service.py | Counted lines: 126 | Lines allowed: 15
ERROR: We found 2 problems and 1 warnings, please check the logfile.

enen92

See comments. Sorry for the time taken.

service.projcontrol/Makefile

@@ -0,0 +1,26 @@
+ADDON_NAME := $(shell grep '<addon id="' addon.xml |cut -d\" -f2)


service.projcontrol/addon.xml

+  </requires>
+  <extension point="xbmc.service" library="service.py" start="login" />
+  <extension point="xbmc.addon.metadata">
+    <platform>all</platform>


service.projcontrol/addon.xml

+    version="1.2.0"
+    provider-name="Fredrik Eriksson">
+  <requires>
+    <import addon="xbmc.python" version="2.19.0"/>


service.projcontrol/addon.xml

+  <extension point="xbmc.service" library="service.py" start="login" />
+  <extension point="xbmc.addon.metadata">
+    <platform>all</platform>
+    <summary lang="en">Control your projector from Kodi</summary>


service.projcontrol/addon.xml

+  <extension point="xbmc.addon.metadata">
+    <platform>all</platform>
+    <summary lang="en">Control your projector from Kodi</summary>
+    <summary lang="sv">Hantera din projektor med Kodi</summary>


service.projcontrol/addon.xml

+    <import addon="script.module.pyserial" version="3.4.0"/>
+  </requires>
+  <extension point="xbmc.service" library="service.py" start="login" />
+  <extension point="xbmc.addon.metadata">


service.projcontrol/lib/infocus.py

+
+        """
+        res = self._send_command("(LMP?)")
+        if res is not None:


service.projcontrol/service.py

+            time_since_stop = datetime.datetime.now() - self._last_power_command_
+            if time_since_stop.days == 0 and time_since_stop.seconds < min_turnaround:
+                log("Screensaver deactivated too soon, will sleep a while before starting projector")
+                xbmc.sleep((min_turnaround-time_since_stop.seconds)*1000)


service.projcontrol/toggle_projector_power.py

+req = urllib2.Request(url, data, headers)
+res = urllib2.urlopen(req)
+
+print(res.read())


service.projcontrol/lib/server.py

+
+import logging
+
+import flask


fredrik-eriksson · 2018-07-26T17:24:24Z

Nice, thanks for the feedback. I had hoped to get this included by making the flask requirement optional, but I can understand why that won't work :)
I've never used bottle, but I'll try to port the API to it instead, thanks for the tip. I'm not really ready to drop the feature as I've found it quite useful.

Regarding platforms I figured this would work on any platform where python (and the dependencies) worked, as long as you know what device name to configure in pyserial. As far as I know I do not use anything that is platform specific. That said, I've only a Linux-machine to test with I'll guess I'll have to restrict it to Linux. The people who connect projectors by serial cables are probably Linux-users anyway :)

As Travis gave a warning about complex entry point I've also done some restructuring. Not sure if it became better or not, but I'll probably need some time to test and make sure everything still works before updating this pull request.

enen92 · 2018-07-26T18:09:41Z

Its fine to keep it for all at the moment. If you find out it won't work on some platform you update it later

petterreinholdtsen · 2018-07-30T23:31:10Z

[Rechi]

This doesn't restrict anything. If <language>_<country> doesn't match your Kodi setting it then tries to match only <language> and then if that doesn't match too, it uses `en_GB` or `en`.

Right, so Kodi is not working as described in RFC 3066, where translations tagged with 'se_NO' would be ignored on systems with locale set to se_SE? Or translations tagged with pt_BR would be ignored on systems with the locale set to pt_PT? For systems behaving according to RFC 3066, I would tag translations only with the 'se' language code to make sure systems with locale set to both se_NO and se_SE would use the translation.

…

-- Happy hacking Petter Reinholdtsen

TravisBuddy · 2018-08-16T17:14:34Z

Travis Buddy

Hey Fredrik Eriksson,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on service.projcontrol
INFO: Created by Fredrik Eriksson
INFO: Addon id matches folder name
ERROR: Required addon script.module.pyserial not available in current repository.
INFO: This is a new addon
INFO: Image icon exists
INFO: Icon dimensions are fine 256x256
INFO: You might want to add a fanart
INFO: epson.py
╒═════╤══════════════════════════════════════╤════════════════════════════════════════════╕
│   # │ Existing Code                        │ Changes required                           │
╞═════╪══════════════════════════════════════╪════════════════════════════════════════════╡
│  59 │ return _valid_sources_[model].keys() │ return list(_valid_sources_[model].keys()) │
╘═════╧══════════════════════════════════════╧════════════════════════════════════════════╛
INFO: infocus.py
╒═════╤══════════════════════════════════════╤════════════════════════════════════════════╕
│   # │ Existing Code                        │ Changes required                           │
╞═════╪══════════════════════════════════════╪════════════════════════════════════════════╡
│  65 │ return _valid_sources_[model].keys() │ return list(_valid_sources_[model].keys()) │
╘═════╧══════════════════════════════════════╧════════════════════════════════════════════╛
ERROR: We found 1 problems and 0 warnings, please check the logfile.

TravisBuddy · 2018-08-16T17:28:22Z

Travis Buddy

Hey Fredrik Eriksson,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on service.projcontrol
INFO: Created by Fredrik Eriksson
INFO: Addon id matches folder name
ERROR: Required addon script.module.pyserial not available in current repository.
INFO: This is a new addon
INFO: Image icon exists
INFO: Icon dimensions are fine 256x256
INFO: You might want to add a fanart
ERROR: We found 1 problems and 0 warnings, please check the logfile.

fredrik-eriksson · 2018-08-16T17:33:20Z

Sorry for the time taken, I think all requested changes has been honored now, and the bottle module seems to work just fine for this plugin. Travis seems happy except for the (obviously) missing pyserial plugin, so I hope this is good enough :)

TravisBuddy · 2018-08-16T17:47:14Z

Travis Buddy

Hey Fredrik Eriksson,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on service.projcontrol
INFO: Created by Fredrik Eriksson
INFO: Addon id matches folder name
ERROR: Required addon script.module.pyserial not available in current repository.
INFO: This is a new addon
INFO: Image icon exists
INFO: Icon dimensions are fine 256x256
INFO: You might want to add a fanart
ERROR: We found 1 problems and 0 warnings, please check the logfile.

enen92 · 2018-08-16T17:50:54Z

Glad to know bottle worked fine for you. Unfortunately I can't merge with travis failing in this repository, we'll have to wait for pyserial to hit our repos (once the repository generator runs again) or someone with higher privileges than myself need to handle it. Pinging @Rechi

petterreinholdtsen mentioned this pull request Jul 23, 2018

[script.module.pyserial] 3.4.0 #867

Merged

3 tasks

enen92 requested changes Jul 26, 2018

View reviewed changes

enen92 added waiting for dependency to be reviewed and removed waiting for dependency to be reviewed labels Jul 26, 2018

[service.projcontrol] 1.3.0

5a611fd

enen92 approved these changes Aug 16, 2018

View reviewed changes

MartijnKaijser merged commit 30a86c8 into xbmc:krypton Aug 16, 2018

fredrik-eriksson deleted the projcontrol branch November 17, 2022 07:00

fredrik-eriksson mentioned this pull request Nov 17, 2022

[service.projcontrol] 1.4.0 #2335

Open

3 tasks

		@@ -0,0 +1,26 @@
		ADDON_NAME := $(shell grep '<addon id="' addon.xml \|cut -d\" -f2)


		import logging

		import flask

[service.projcontrol] 1.2.0 #868

[service.projcontrol] 1.2.0 #868

Uh oh!

Conversation

fredrik-eriksson commented Jul 12, 2018

Description

Checklist:

Uh oh!

TravisBuddy commented Jul 12, 2018

Travis Buddy

1st Build

Uh oh!

enen92 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

fredrik-eriksson commented Jul 26, 2018

Uh oh!

enen92 commented Jul 26, 2018

Uh oh!

petterreinholdtsen commented Jul 30, 2018 via email

Uh oh!

TravisBuddy commented Aug 16, 2018

Travis Buddy

1st Build

Uh oh!

TravisBuddy commented Aug 16, 2018

Travis Buddy

1st Build

Uh oh!

fredrik-eriksson commented Aug 16, 2018

Uh oh!

TravisBuddy commented Aug 16, 2018

Travis Buddy

1st Build

Uh oh!

enen92 commented Aug 16, 2018

Uh oh!

Uh oh!