Skip to content

Conversation

fredrik-eriksson
Copy link

Description

The pyserial python module packaged for kodi. This package will be required for my projcontrol service addon.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@TravisBuddy

This comment has been minimized.

1 similar comment
@TravisBuddy
Copy link

Travis Buddy

Hey Fredrik Eriksson,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@petterreinholdtsen
Copy link

Any news on this? Anything we should do differently? As you probably am aware, the #868 pull request depend on this one to go in first.

@enen92
Copy link
Member

enen92 commented Jul 25, 2018

@petterreinholdtsen @fredrik-eriksson we could not yet find time to review it. Please be patient.
I'll try to have a look tomorrow.

Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the author and license needs adjustment

@@ -0,0 +1,29 @@
BSD 3-Clause License

This comment was marked as spam.

<addon id="script.module.pyserial"
name="pyserial"
version="3.4.0"
provider-name="feffe">

This comment was marked as spam.

<license>BSD-3-Clause</license>
<forum></forum>
<website>https://github.com/pyserial/pyserial</website>
<source>https://github.com/fredrik-eriksson/script.module.pyserial</source>

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@TravisBuddy
Copy link

Travis Buddy

Hey Fredrik Eriksson,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants