Skip to content

Conversation

@rolandlo
Copy link
Contributor

@rolandlo rolandlo commented Oct 29, 2023

Depends on #110

Re-opens #705 - was merged by accident.

* library: Port Actions demo to Python

* Add Link to PyGObjects docs in Actions demo
@sonnyp sonnyp force-pushed the revert-705-actions-demo-python branch from c3400d8 to 5306cf8 Compare October 29, 2023 11:49
@sonnyp sonnyp marked this pull request as draft October 29, 2023 11:49
@sonnyp sonnyp changed the title Revert 705 actions demo python library: Port Actions demo to Python Oct 29, 2023
Copy link
Contributor

@theCapypara theCapypara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned in the previous PR LGTM. We may want to wait for #110 and also #716.

@theCapypara
Copy link
Contributor

I pushed a commit to apply the new formatting of #716 - now the only thing potentially blocking is the broken actions. Sonny will check that one again as well and we will see if we will merge now or wait for #110.

@theCapypara theCapypara marked this pull request as ready for review October 29, 2023 18:29
@theCapypara
Copy link
Contributor

Sonny gave the go 🚀
Thank you!

@theCapypara theCapypara merged commit 4891bd5 into main Oct 29, 2023
@sonnyp sonnyp deleted the revert-705-actions-demo-python branch October 29, 2023 18:59
Comment on lines +165 to +169
LinkButton {
label: _("PyGObjects Documentation");
uri: "https://pygobject.readthedocs.io";
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link isn't specific to Actions - it doesn't belong here.

I will move it to the bookmarks menu. If there is PyGObject specific documentation for actions - let me know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Not really, just the API docs.

gregorni pushed a commit that referenced this pull request Oct 29, 2023
---------

Co-authored-by: Marco Capypara Köpcke <[email protected]>
lw64 pushed a commit that referenced this pull request Dec 18, 2023
---------

Co-authored-by: Marco Capypara Köpcke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants