library: Port Actions demo to Python

[rolandlo]

This PR ports the Actions demo to Python

I have tried to stay as close as possible to the JS code. Not sure if I should have avoided using lambdas as in the Welcome demo, see comment. I used lambdas because here it's only for a single statement, whereas in the Welcome demo there were two statements.

The open_uri actions somehow don't work yet. Is this something that needs to be fixed on the "core" side or is there something wrong with my code?

[Hofer-Julian]

I used lambdas because here it's only for a single statement

If it's only a single statement, it's fine to use lambdas IMO

[sonnyp]

I'll leave it to @theCapypara to review his first Workbench PR :)

@rolandlo thanks! please consider adding yourself to the list of contributors in about.js

[sonnyp]

@theCapypara please do make sure to test the code, pasting the code directly into Workbench is the most efficient way for ports

[rolandlo]

@rolandlo thanks! please consider adding yourself to the list of contributors in about.js

Done!

[theCapypara]

Thanks! In general this looks good and works perfectly, however could you make sure your code is formatted to follow PEP 8 and uses 4 spaces for indentation?

You can use pycodestyle to verify. You can ignore error E402 module level import not at top of file, since that isn't possible due to the require_version.

Also we may want to change the demo's blueprint file to also link to the PyGObject docs (or remove the GJS link), what do you think @sonnyp?

[theCapypara]

One example for PEP 8 is that there should be no spaces around the = in keyword arguments.

[rolandlo]

Thanks! In general this looks good and works perfectly, however could you make sure your code is formatted to follow PEP 8 and uses 4 spaces for indentation?

You can use pycodestyle to verify. You can ignore error E402 module level import not at top of file, since that isn't possible due to the require_version.

Done! It would be good to add these style requirements to the style guide, so everybody can learn about them without going through previous PR's.

Also we may want to change the demo's blueprint file to also link to the PyGObject docs (or remove the GJS link), what do you think @sonnyp?

I have added a commit adding that link. Let me know if I should remove the commit (or make changes to it).

Back to:

The open_uri actions somehow don't work yet. Is this something that needs to be fixed on the "core" side or is there something wrong with my code?

Is it only for me that the links from the bookmarks don't work (the links are not opened) with the Python code and the Actions Documentation section is disabled?

[theCapypara]

Oh, that's very odd, I somehow didn't even notice that the first time around.
Must be an issue in PyGObject, somehow? It's really odd since there's no code in either the JS/Python demo related to that, but I can't really imagine how the language bindings would break this.

However looking at the inspector it seems the "sensitive" property for the generated ModelButtons is somehow filled with the label...

[theCapypara]

Oh wow, wait, disregard my previous comment even though I double and tripple checked before sending (and was very confused how this is even possible) I just was off by one line. That is the text.

[theCapypara]

Okay this is not a bug in PyGObject, this is a general issue with the way the external previewers work at the moment: #715

[rolandlo]

Should I squash all the commits (or at least the first two commits) into one?

[sonnyp]

Converting to draft until #715 is solved.

[sonnyp]

Should I squash all the commits (or at least the first two commits) into one?

No need, our default merging strategy is "Squash and merge"

[theCapypara]

IMO we could still merge this. There are already some other demos broken right now because of #715 / #110
And this is only a minor part of that demo.

[rolandlo]

Ok then, let's squash and merge.

[sonnyp]

@rolandlo please don't merge PRs. It is a task for maintainers.

Feel free to create branches though.