Skip to content

Data-only notifications should not show empty notifications #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Data-only notifications should not show empty notifications #780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7b7c33
Don't post a notification if there is no title and no body set.
callaars Aug 3, 2021
f1d4a70
Update PushNotification.java
callaars Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...pp/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ public PushNotificationProps asProps() {
}

protected int postNotification(Integer notificationId) {
if (mNotificationProps.getTitle() == null && mNotificationProps.getBody() == null) {
return -1;
}

final PendingIntent pendingIntent = getCTAPendingIntent();
final Notification notification = buildNotification(pendingIntent);
return postNotification(notification, notificationId);
Expand Down