Skip to content

Conversation

@callaars
Copy link

@callaars callaars commented Oct 1, 2021

As described in this issue #684 notifications are displayed as empty notifications in Android when no title and body is set.

This PR mitigates that by not creating a notification if both are not available.

I couldn't find a CONTRIBUTING file so I'm just pushing this as a PR. Let me know if something is off or needs fixing. I've tested this, obviously, and it works as intended.

@callaars callaars requested a review from yogevbd as a code owner October 1, 2021 08:28
@callaars callaars changed the title Fix android empty notification Data-only notifications should not show empty notifications Oct 1, 2021
@callaars
Copy link
Author

callaars commented Oct 1, 2021

cc @VitalyArt / @yogevbd

@stale
Copy link

stale bot commented Nov 15, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Nov 15, 2021
@callaars
Copy link
Author

You are stale.

@stale stale bot removed the 🏚 stale label Nov 15, 2021
@anatooly
Copy link

anatooly commented Nov 30, 2021

At current last version
"react-native-notifications": "^4.1.2",

I don't see push text. Only application title & empty body,
samsung a30, android 11
in iOS all correct

@stale
Copy link

stale bot commented Jan 17, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Jan 17, 2022
@stale
Copy link

stale bot commented Jan 24, 2022

The issue has been closed for inactivity.

@stale stale bot closed this Jan 24, 2022
@artdevgame
Copy link
Contributor

This PR is not stale. I'm experiencing the same issue. Please can a contributor help get this work merged.

@callaars
Copy link
Author

callaars commented Feb 9, 2022

It's definitely still happening.

@artdevgame
Copy link
Contributor

@DanielEliraz Can I bring your attention to this fix too please?

@DanielEliraz
Copy link
Collaborator

OK, accepting! thanks @callaars!

@DanielEliraz
Copy link
Collaborator

@callaars replaced it with a new PR, thanks man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants