Skip to content

Give all bodies a stream #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Give all bodies a stream #1177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fa49c0
Give all bodies a stream
annevk Feb 19, 2021
dacac24
nit
annevk Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions fetch.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,8 +1001,7 @@ worked on in <a href=https://github.com/whatwg/fetch/issues/1156>issue #1156</a>
<p>A <dfn export id=concept-body>body</dfn> consists of:

<ul>
<li><p>A <dfn export for=body id=concept-body-stream>stream</dfn> (null or a {{ReadableStream}}
object).
<li><p>A <dfn export for=body id=concept-body-stream>stream</dfn> (a {{ReadableStream}} object).

<li><p>A <dfn export for=body id=concept-body-transmitted>transmitted bytes</dfn>
(an integer), initially 0.
Expand Down Expand Up @@ -4105,30 +4104,21 @@ steps. They return a <a for=/>response</a>.
<p>Otherwise:

<ol>
<li><p>Set <var>httpRequest</var> to a copy of <var>request</var> except for its
<a for=request>body</a>.

<li><p>Let <var>body</var> be <var>request</var>'s <a for=request>body</a>.

<li><p>Set <var>httpRequest</var>'s <a for=request>body</a> to <var>body</var>.
<li>
<p>Set <var>httpRequest</var> to a <a for=request>clone</a> of <var>request</var>.

<li><p>If <var>body</var> is non-null, then set <var>request</var>'s <a for=request>body</a> to
a new <a for=/>body</a> whose <a for=body>stream</a> is null and whose <a for=body>source</a>
is <var>body</var>'s <a for=body>source</a>.
<p class=note>Implementations are encouraged to avoid teeing <var>request</var>'s
<a for=request>body</a>'s <a for=body>stream</a> when <var>request</var>'s
<a for=request>body</a>'s <a for=body>source</a> is null as only a single body is needed in
that case. E.g., when <var>request</var>'s <a for=request>body</a>'s <a for=body>source</a>
is null, redirects and authentication will end up failing the fetch.

<li><p>Set <var>httpFetchParams</var> to a copy of <var>fetchParams</var>.

<li><p>Set <var>httpFetchParams</var>'s <a for="fetch params">request</a> to
<var>httpRequest</var>.
</ol>

<p class="note no-backref"><var>request</var> is copied as <var>httpRequest</var> here as we
need to be able to add headers to <var>httpRequest</var> and read its <a for=request>body</a>
without affecting <var>request</var>. Namely, <var>request</var> can be reused with redirects,
authentication, and proxy authentication. We copy rather than clone in order to reduce memory
consumption. In case <var>request</var>'s <a for=request>body</a>'s <a for=body>source</a> is
null, redirects and authentication will end up failing the fetch.

<li>
<p>Let <var>includeCredentials</var> be true if one of

Expand Down