Give all bodies a stream #1177
Merged
Give all bodies a stream #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Feb 19, 2021
There was a problem hiding this comment.
I'm not sure I fully understand this; perhaps @yutakahirano would be a better reviewer?
annevk
commented
Feb 22, 2021
fetch.bs
Outdated
| <p class=note>Implementations are encouraged to avoid teeing <var>request</var>'s | ||
| <a for=request>body</a>'s <a for=body>stream</a> when <var>request</var>'s | ||
| <a for=request>body</a>'s <a for=body>source</a> is null as only a single body is needed in | ||
| that case. That is, when <var>request</var>'s <a for=request>body</a>'s <a for=body>source</a> |
There was a problem hiding this comment.
Maybe s/That is/e.g.,/ as we are getting more such examples, such as 421.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies some wording introduced in #425 and aligns it with the recently introduced cloning for service workers.
Fixes #1176.
Preview | Diff