BREAKING CHANGE: remove socket option #2669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #2669 +/- ##
==========================================
- Coverage 92.53% 92.51% -0.02%
==========================================
Files 37 37
Lines 1312 1310 -2
Branches 355 354 -1
==========================================
- Hits 1214 1212 -2
Misses 93 93
Partials 5 5
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Jul 3, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Tests still unstable 😞
hiroppy
approved these changes
Jul 7, 2020
Member
hiroppy
left a comment
hiroppy
left a comment
There was a problem hiding this comment.
The CI fails by audit and it hasn't fixed yet. anyway LGTM
alexander-akait
approved these changes
Jul 7, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
Remove socket option
Breaking Changes
socketoption removedAdditional Info