This repository was archived by the owner on Dec 22, 2020. It is now read-only.
feat: use multi-line comment to support .css syntax #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
In some scenarios, a JS module may import a .css file and then webpack will process it with say, postcss-loader & css-loader.
If you need to nullify that .css file using this loader, the output of null-loader won't be valid CSS since CSS does not support single line comments // ... and thus, css-loader or postcss-loader will throw an error (SyntaxError) and webpack will stop bundling.
Test Plan
Using the newly added test file. We use css-loader to check if the transformed output is a valid css.
Before (using single-line)
After (using multi-line)
Related PR
This is an attempt to continue #20. It seems that there is no sign of it's work will be continued by the author.
Close #20