Skip to content
This repository was archived by the owner on Dec 22, 2020. It is now read-only.

Conversation

@tubalmartin
Copy link

@tubalmartin tubalmartin commented Apr 26, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

In some scenarios, such as the one I encountered at my current company, a JS module may import a .css file and then webpack will process it with say, postcss-loader & css-loader.

If you need to nullify that .css file using this loader, the output of null-loader won't be valid CSS since CSS does not support single line comments // ... and thus, css-loader or postcss-loader will throw an error (SyntaxError) and webpack will stop bundling.

Since both CSS and JS support multi-line or block comments /* ... */ I think it's sensible to use this form instead of single line comments.

Breaking Changes

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Apr 26, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Túbal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@alexander-akait
Copy link
Member

Need test

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files           2        2           
  Lines           9        9           
  Branches        1        1           
=======================================
  Hits            7        7           
  Misses          2        2
Impacted Files Coverage Δ
src/index.js 66.66% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84998aa...e42808b. Read the comment docs.

@tubalmartin
Copy link
Author

@evilebottnawi what test?

@alexander-akait
Copy link
Member

@alexander-akait
Copy link
Member

Close in favor #24

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants