This repository was archived by the owner on Dec 22, 2020. It is now read-only.
feat: added support for .css files imported by Js modules #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
In some scenarios, such as the one I encountered at my current company, a JS module may import a
.cssfile and then webpack will process it with say, postcss-loader & css-loader.If you need to nullify that
.cssfile using this loader, the output of null-loader won't be valid CSS since CSS does not support single line comments// ...and thus, css-loader or postcss-loader will throw an error (SyntaxError) and webpack will stop bundling.Since both CSS and JS support multi-line or block comments
/* ... */I think it's sensible to use this form instead of single line comments.Breaking Changes
Additional Info