Skip to content

[Snyk] Security upgrade axios from 0.27.2 to 1.12.0 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[Snyk] Security upgrade axios from 0.27.2 to 1.12.0 #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"dependencies": {
"@babel/runtime": "^7.17.9",
"axios": "^0.27.2",
"axios": "^1.12.0",
Copy link

@gemini-code-assist gemini-code-assist bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade is correct for this file, but the fix is incomplete. The axios dependency in templates/react-app/package.json also needs to be upgraded from ^0.27.2 to ^1.12.0 to fully patch the security vulnerability across all project templates.

Copy link

@gemini-code-assist gemini-code-assist bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While upgrading axios resolves the security vulnerability for this template, it appears this dependency might be unused within the app template's source code (e.g., templates/app/src/index.ts). If axios is indeed an unused dependency for this template, the best practice would be to remove it entirely. This would reduce the final bundle size and minimize the project's attack surface.

If it's intended as a placeholder for developers, then this upgrade is acceptable.

Copy link

@gemini-code-assist gemini-code-assist bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While this upgrade is correct, the same dependency in templates/react-app/package.json has not been updated. It is still using the vulnerable version ^0.27.2. To fully address the security vulnerability and maintain consistency, please update the axios version in templates/react-app/package.json as well.

"core-js": "^3.22.3",
"web-vitals": "^2.1.4"
},
Expand Down