Skip to content

Clarify non-normative short trace-id considerations in section 8.4 #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Clarify non-normative short trace-id considerations in section 8.4 #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion spec/60-trace-id-format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ identifiers SHOULD be left padded with zeros when converted to 16 bytes
`trace-id` and rightmost part of `trace-id` SHOULD be used as a shorter
identifier.

Note, many existing systems that are not capable of propagating the whole
Notes:
* Many existing systems that are not capable of propagating the whole
`trace-id` will not propagate `tracestate` header either. However, such system
can still use `tracestate` header to propagate additional data that is known by
this system. For example, some systems use two flags indicating whether
Expand All @@ -73,3 +74,9 @@ and receive an additional flag. Compliant systems will propagate this flag along
all other key/value pairs. Existing systems which are not capable of
`tracestate` propagation will truncate all additional values from `tracestate`
and only pass along that flag.

* This section provides guidance for dealing with short `trace-id`s generated by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this point is wrong. we are not providing guidance for accepting short trace ids from non-compliant systems, but rather for systems which want to be compliant but can only process an 8 byte id.

@SergeyKanzhelev

non-compliant legacy systems. It is non-normative, and does not alter the normative
requirements of `trace-id` length in other portions of this spec. Nor does it imply that
`traceparent` headers which do not meet this spec's normative requirements should be
accepted.