Clarify non-normative short trace-id considerations in section 8.4 #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
approved these changes
Jan 29, 2020
dyladan
approved these changes
Jan 29, 2020
dyladan
reviewed
Jan 29, 2020
| `tracestate` propagation will truncate all additional values from `tracestate` | ||
| and only pass along that flag. | ||
|
|
||
| * This section provides guidance for dealing with short `trace-id`s generated by |
There was a problem hiding this comment.
I think this point is wrong. we are not providing guidance for accepting short trace ids from non-compliant systems, but rather for systems which want to be compliant but can only process an 8 byte id.
|
After conversation in the related issue, I'm closing this PR as unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes section 8.4, which is a non-normative section describing considerations when dealing with
trace-id. This PR attempts to clarify that this non-normative section does not change thetrace-idlength requirement specified in section 3.2.Fixes #379