Skip to content

Conversation

@sethidden
Copy link
Contributor

Description

Fixed the reported issue where adding items from the list view would add them to cart always with quantity 1, even if the user provided something else eg. 1337

Since it's a change to business logic I really wanted to write some tests for this, but there's a lot of boilerplate code to even start (which would turn this 5 min task into a 6 hour one)

Also fixed some linting errors as husky started bothering me because I touched the file

Related Issue

#662

How Has This Been Tested?

Tested manually the two scenarios:

  1. Add many products to cart (e.g. 1337)
  2. Add one (to check if the value "null" is not emitted or something when there's just 1 - there's not)

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Also made some minor eslint fixes since I "touched" the file and husky
started detecting them
@sethidden sethidden force-pushed the bugfix/M2-210-category-quantity-input-value-omitted-when-adding-product-to-cart branch from abd0a0b to b2fa268 Compare March 2, 2022 13:07
@sethidden sethidden merged commit aac1472 into develop Mar 2, 2022
@sethidden sethidden deleted the bugfix/M2-210-category-quantity-input-value-omitted-when-adding-product-to-cart branch March 2, 2022 17:33
@Frodigo Frodigo added this to the 1.0.0-rc.7 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants