Skip to content

feat(theme): add basic skeleton loader component #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2022
Merged

feat(theme): add basic skeleton loader component #681

merged 1 commit into from
Mar 3, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Mar 2, 2022 •
edited
Loading

Description

I added a new basic SkeletonLoader component.
This is the first iteration, we must decompose category further.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

-vue-storefront-magento-theme

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions github-actions bot assigned bartoszherba and unassigned Frodigo Mar 2, 2022
@bartoszherba bartoszherba force-pushed the M2-226-implement-loading-skeletons branch from 342d2dc to 328da28 Compare March 3, 2022 08:11
sethidden
sethidden requested changes Mar 3, 2022
View reviewed changes
@bartoszherba bartoszherba force-pushed the M2-226-implement-loading-skeletons branch from 328da28 to 4e88f02 Compare March 3, 2022 09:25
@bartoszherba bartoszherba requested a review from sethidden March 3, 2022 09:26
@bartoszherba bartoszherba force-pushed the M2-226-implement-loading-skeletons branch from 4e88f02 to 29b9b3c Compare March 3, 2022 10:01
sethidden
sethidden reviewed Mar 3, 2022
View reviewed changes
sethidden
sethidden reviewed Mar 3, 2022
View reviewed changes
@bartoszherba bartoszherba force-pushed the M2-226-implement-loading-skeletons branch 2 times, most recently from 47ae3e1 to 13da382 Compare March 3, 2022 11:13
@bartoszherba bartoszherba force-pushed the M2-226-implement-loading-skeletons branch from 13da382 to 5f03c1a Compare March 3, 2022 11:13
@sethidden sethidden self-requested a review March 3, 2022 11:21
@bartoszherba bartoszherba requested a review from sethidden March 3, 2022 11:44
@bartoszherba bartoszherba merged commit 867cc84 into develop Mar 3, 2022
@bartoszherba bartoszherba deleted the M2-226-implement-loading-skeletons branch March 3, 2022 11:59
@Frodigo Frodigo added this to the 1.0.0-rc.7 milestone Mar 3, 2022
@sethidden sethidden mentioned this pull request Mar 8, 2022
Merged
9 tasks
@Frodigo Frodigo mentioned this pull request May 10, 2022
Merged
@Frodigo Frodigo mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethidden sethidden sethidden approved these changes

Assignees

@bartoszherba bartoszherba

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.7

Development

Successfully merging this pull request may close these issues.

4 participants

@bartoszherba @sethidden @Frodigo