Allowed passing a tsconfig.json to --comments #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingDarBoja
reviewed
Sep 12, 2020
JoshuaKGoldberg
added
the
status: waiting for author
JoshuaKGoldberg
added
status: waiting for reviewer
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
As described by the issue, allows a string that ends with
.jsonto be counted as a new TypeScript configuration to read from disk. In theory we could reuse the existing configuration if it's the same as--typescript, but that seems like both a rare case and not a significant performance penalty.Extracts the logic to take
--commentsglobs & existing TS config into a new injected function. This wasn't strictly necessary but they were getting pretty chunky.