Replace fs promises api with utils.promisify #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
added
the
status: waiting for reviewer
JoshuaKGoldberg
requested changes
Jul 2, 2019
JoshuaKGoldberg
added
status: waiting for author
|
For testing this change: to recap an offline conversation, exercising that file writing works could be done with a single |
JoshuaKGoldberg
requested changes
Jul 2, 2019
There was a problem hiding this comment.
Oh shoot sorry @egiurleo I just noticed: https://github.com/egiurleo/tslint-to-eslint-config/blob/0620e729b8d9490f406659afd4ca54403721226e/src/adapters/fsFileSystem.ts#L25
That usage of fs.promises will need to be replaced too. Could you please make that change?
egiurleo
commented
Jul 3, 2019
JoshuaKGoldberg
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This PR replaces the
fs.promisesAPI withutil.promisifyin order to support Node 8.x.Edit: Not sure how to test this change.