-
Notifications
You must be signed in to change notification settings - Fork 101
Closed
Labels
good first issueGood for newcomers; welcome aboard!Good for newcomers; welcome aboard!status: accepting prsPlease, send in a PR to resolve this! ✨Please, send in a PR to resolve this! ✨type: enhancementNew feature or requestNew feature or request
Milestone
Description
🚀 Feature Request
Node 8 is still in LTS through the end of 2019 (though Node 6 is not anymore, hooray!). tslint-eslint-config should explicitly support it.
Existing Behavior
Instead, tslint-eslint-config crashes silently when run in Node 8. Darn.
Change Proposal
Usage of the new .promises APIs, e.g. fs.promises (https://nodejs.org/dist/latest-v10.x/docs/api/fs.html#fs_fs_promises_api), is experimental in Node 10 and not available in Node 8. Any usage of this:
import * as fs from "fs";
// ...
await fs.promises.readFile("...");...should be replaced by something like:
import * as fs from "fs";
import { promisify } from "utils";
const readFile = promisify(fs.readFile);
// ...
await readFile("...");Metadata
Metadata
Assignees
Labels
good first issueGood for newcomers; welcome aboard!Good for newcomers; welcome aboard!status: accepting prsPlease, send in a PR to resolve this! ✨Please, send in a PR to resolve this! ✨type: enhancementNew feature or requestNew feature or request