Authenticate operations in KeyspaceService #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-scoppetta
approved these changes
Aug 13, 2019
vmax
added a commit
to typedb/typedb
that referenced
this pull request
Aug 14, 2019
## What is the goal of this PR? typedb/typedb-protocol#7 obsoletes `create` RPC method from `KeyspaceService`. This PR prepares Grakn Core for this change. ## What are the changes implemented in this PR? Remove dummy method implementation
vmax
added a commit
to typedb/typedb-driver
that referenced
this pull request
Aug 14, 2019
## What is the goal of this PR? Recent changes in protocol (typedb/typedb-protocol#7) allow keyspace operations to be authenticated. This PR adapts Grakn Client Java to these recent changes. ## What are the changes implemented in this PR? - Builder methods in `RequestBuilder.Keyspace` now accept `username` and `password` - `Keyspaces` constructor now accepts `username` and `password` - Bump `@graknlabs_protocol` to latest version
vmax
added a commit
to typedb/typedb-driver-nodejs
that referenced
this pull request
Aug 14, 2019
## What is the goal of this PR? Recent changes in protocol (typedb/typedb-protocol#7) allow keyspace operations to be authenticated. This PR adapts Grakn Client NodeJS to these recent changes. ## What are the changes implemented in this PR? - `KeyspaceService.retrieve` and `KeyspaceService.delete` now properly set credentials - Bump `@graknlabs_protocol` and `@graknlabs_grakn_core` to latest version
vmax
added a commit
to typedb/typedb-driver-python
that referenced
this pull request
Aug 20, 2019
## What is the goal of this PR? Recent changes in protocol (typedb/typedb-protocol#7) allow keyspace operations to be authenticated. This PR adapts Grakn Client Python to these recent changes. ## What are the changes implemented in this PR? - `KeyspaceService.retrieve` and `KeyspaceService.delete` now properly set credentials - Bump `@graknlabs_protocol` and `@graknlabs_grakn_core` to latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Operations with keyspaces need to be authenticated with
username/passwordin enterprise version. In order to support that, protocol needs to be changed. Additionally, RPC method to create keyspace is now obsolete and needs to be removed.What are the changes implemented in this PR?
createRPC method as well asCreate.Req/Create.ResusernameandpasswordinRetrieve.ReqandDelete.Req