This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Supply authentication credentials for keyspace operations #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if (this.credentials.password !== undefined) { | ||
| retrieveRequest.setPassword(this.credentials.password); | ||
| } |
There was a problem hiding this comment.
I think you can just:
if(this.credentials){
retrieveRequest.setUsername(this.credentials.username);
retrieveRequest.setPassword(this.credentials.password);
}
Your code should throw exception if this.credentials is null, have you run the tests already?
There was a problem hiding this comment.
@marco-scoppetta addressed in 2ebb12b
I currently have a problem running tests locally (even on non-modified master) so I relied on CI here. Good catch!
There was a problem hiding this comment.
Strange, I don't see the tests being run on CI either
marco-scoppetta
approved these changes
Aug 14, 2019
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-client-nodejs
that referenced
this pull request
Sep 1, 2023
## What is the goal of this PR? Adapt `@graknlabs_client_java` to latest changes in bazel-distribution (in particular, typedb/bazel-distribution#150) ## What are the changes implemented in this PR? Instead of supplying `version_file` everywhere, use `--define version=<>` as a Bazel argument to supply version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Recent changes in protocol (typedb/typedb-protocol#7) allow keyspace operations to be authenticated. This PR adapts Grakn Client NodeJS to these recent changes.
What are the changes implemented in this PR?
KeyspaceService.retrieveandKeyspaceService.deletenow properly set credentials@graknlabs_protocoland@graknlabs_grakn_coreto latest version