Skip to content

Follow ups for 64 bit change #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

jeromekelleher
Copy link
Member

Closes #1628

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1651 (a6d8984) into main (03a4472) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a6d8984 differs from pull request most recent head 05b5f18. Consider uploading reports for the commit 05b5f18 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1651   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files          27       27           
  Lines       23322    23326    +4     
  Branches     1084     1084           
=======================================
+ Hits        21858    21862    +4     
  Misses       1430     1430           
  Partials       34       34           
Flag Coverage Δ
c-tests 91.88% <100.00%> (+<0.01%) ⬆️
lwt-tests 93.49% <ø> (ø)
python-c-tests 95.48% <ø> (ø)
python-tests 98.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/core.c 97.23% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a4472...05b5f18. Read the comment docs.

@jeromekelleher jeromekelleher changed the title Follw ups for 64 bit change Follow ups for 64 bit change Sep 1, 2021
@jeromekelleher
Copy link
Member Author

Note to self - typo in comments for tsk_calloc

@jeromekelleher jeromekelleher marked this pull request as ready for review September 3, 2021 10:44
@benjeffery
Copy link
Member

LGTM, ready to merge?

@mergify mergify bot merged commit 705640b into tskit-dev:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up for 64 bit tsk_size_t
2 participants