Skip to content

Follow-up for 64 bit tsk_size_t #1628

@jeromekelleher

Description

@jeromekelleher

After #1618 is merged there's a few tidy up tasks needed

  • Bump TSK_FILE_FORMAT_VERSION_MINOR to 5. Arguably we don't need to bother with this because the file format is identical as far as existing code is concerned, unless 64 bit columns are output. No harm in marking the change, though.
  • In tsk_malloc, return NULL if size > SIZE_MAX. We can probably put this in a #def, like if TSK_SIZE_MAX > SIZE_MAX or something, to avoid compiler complaints in the nominal case
  • Document 64 bit change and behaviour of the file format.
  • Update changelogs
  • Review issues related to 64 bit-ness and close as appropriate.

Anything else occur to you @benjeffery?

It'll be good to get the patch merged soon now I think, as it'll grow stale quickly.

Metadata

Metadata

Labels

C APIIssue is about the C API

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions