Skip to content

Update tree-sitter-javascript #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

Update tree-sitter-javascript #229

merged 1 commit into from
Dec 6, 2022

Conversation

@Shraymonks
Copy link
Contributor

@Shraymonks Shraymonks commented Dec 2, 2022

Updates tree-sitter-javascript and fixes grammar to support updated rules.

Changes:
tree-sitter/tree-sitter-javascript#234
tree-sitter/tree-sitter-javascript#235

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

mjambon
mjambon approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@mjambon mjambon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@mjambon mjambon merged commit faad909 into tree-sitter:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mjambon mjambon mjambon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Shraymonks @mjambon