Skip to content

Conversation

@Shraymonks
Copy link
Contributor

@Shraymonks Shraymonks commented Nov 28, 2022

Add support for static blocks in classes. Fixes #222

References:
MDN
TC39 spec

Checklist:

  • All tests pass in CI.
  • The script/parse-examples passes without issues.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@aryx
Copy link
Contributor

aryx commented Nov 29, 2022

you can probably rebase on latest to fix the windows CI failure.

@Shraymonks
Copy link
Contributor Author

you can probably rebase on latest to fix the windows CI failure.

Rebased!

Copy link
Contributor

@maxbrunsfeld maxbrunsfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static class initialization block

3 participants