Skip to content

Use importlib.metadata from the standard library on Python 3.8+ #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2019
Merged

Use importlib.metadata from the standard library on Python 3.8+ #1368

merged 2 commits into from
Jul 8, 2019

Conversation

@hroncok
Copy link
Contributor

@hroncok hroncok commented Jul 8, 2019 •
edited by gaborbernat
Loading

Resolves #1367

@hroncok hroncok mentioned this pull request Jul 8, 2019
Closed
asottile
asottile approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gaborbernat
gaborbernat reviewed Jul 8, 2019
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pull in here 3.8 to test this?

https://github.com/tox-dev/tox/blob/master/azure-pipelines.yml#L32

      py38:
        image: [linux]

So we test this inside the CI too?

@hroncok hroncok force-pushed the importlib_metadata branch from 7ef798f to 718704f Compare July 8, 2019 17:41
@hroncok
Copy link
Contributor Author

hroncok commented Jul 8, 2019

Can you pull in here 3.8 to test this?

Separate commit?

@gaborbernat
Copy link
Member

gaborbernat commented Jul 8, 2019

Here is perfect 👍

@hroncok
Copy link
Contributor Author

hroncok commented Jul 8, 2019

Azure Pipelines failed on various Windows. I don't think it is related.

@gaborbernat
Copy link
Member

gaborbernat commented Jul 8, 2019

That's alright 👍

@gaborbernat gaborbernat merged commit f6c42eb into tox-dev:master Jul 8, 2019
@gaborbernat
Copy link
Member

gaborbernat commented Jul 8, 2019

Thanks!

@hroncok hroncok deleted the importlib_metadata branch July 8, 2019 18:12
@hroncok
Copy link
Contributor Author

hroncok commented Jul 8, 2019

Thanks for the absolutely swift review!

@hroncok hroncok mentioned this pull request Sep 10, 2019
Merged
@hroncok hroncok mentioned this pull request Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@obestwalter obestwalter Awaiting requested review from obestwalter

+1 more reviewer

@asottile asottile asottile approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use importlib.metadata from the standard library on Python 3.8

3 participants

@hroncok @gaborbernat @asottile