This repository was archived by the owner on Oct 17, 2024. It is now read-only.
ci: add musllinux_1_1 wheels #3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,6 @@ requires = [ | |
|
|
||
| [project] | ||
| name = "pyproject-fmt-rust" | ||
|
Member
There was a problem hiding this comment. Do you have a link where they say you can do that? 🤣 At the very least the version should be dynamic otherwise it's violating pep 621...
Contributor
Author
There was a problem hiding this comment. It is. Check below. ;) It previously was violating PEP 621 by having both static and dynamic versions. https://www.maturin.rs/metadata (at the top)
Contributor
Author
There was a problem hiding this comment. I can't comment on it, but see line 32. |
||
| description = "Format your pyproject.toml file" | ||
| readme = "README.md" | ||
| keywords = [ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the cargo and project.toml file to 1.0.2 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't Maturin read the version number from Cargo.toml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see a way to do that so unless I'm blind I feel not...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's listed in both dynamic and directly, that's incorrect. Will try removing from pyproject.toml, it says in the docs that they are merged.