Skip to content
This repository was archived by the owner on Oct 17, 2024. It is now read-only.

Conversation

@henryiii
Copy link
Contributor

This adds musllinux, and since I figured out how to target 1_1, went ahead and targeted it here.

By the way, the i686 manglinux wheel is getting tagged as manylinux1, while all the others are getting the (correct) manylinux2014 tags. Not sure why it would be different.

target: x86_64
- runner: ubuntu-latest
target: x86
- runner: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the cargo and project.toml file to 1.0.2 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't Maturin read the version number from Cargo.toml?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see a way to do that so unless I'm blind I feel not...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's listed in both dynamic and directly, that's incorrect. Will try removing from pyproject.toml, it says in the docs that they are merged.

henryiii added 3 commits May 11, 2024 01:10
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/ci/try-musl2 branch from 305685c to 9cfc915 Compare May 11, 2024 05:11

[project]
name = "pyproject-fmt-rust"
version = "1.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link where they say you can do that? 🤣 At the very least the version should be dynamic otherwise it's violating pep 621...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. Check below. ;) It previously was violating PEP 621 by having both static and dynamic versions.

https://www.maturin.rs/metadata (at the top)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on it, but see line 32.

@gaborbernat gaborbernat merged commit 6249ab4 into tox-dev:main May 11, 2024
@henryiii henryiii deleted the henryiii/ci/try-musl2 branch May 11, 2024 05:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants