Drop Python 3.9 #987

tony · 2025-11-01T15:03:38Z

Changes

Drop Python 3.9

EOL of 2025-10-31.

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.08%. Comparing base (c13914a) to head (4a40ac0).
⚠️ Report is 15 commits behind head on master.

Files with missing lines	Patch %	Lines
docs/_ext/aafig.py	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
+ Coverage   73.03%   73.08%   +0.04%     
==========================================
  Files          26       26              
  Lines        1858     1854       -4     
  Branches      352      352              
==========================================
- Hits         1357     1355       -2     
+ Misses        397      395       -2     
  Partials      104      104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

See also: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

See also: - https://docs.astral.sh/ruff/settings/#target-version - Python 3.9 EOL: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

See also: - https://mypy.readthedocs.io/en/stable/config_file.html#confval-python_version - Python 3.9 EOL: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

See also: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

uv run ruff check . --fix --show-fixes Fixed 20 errors: - src/tmuxp/_internal/config_reader.py: 1 × UP035 (deprecated-import) - src/tmuxp/cli/__init__.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/cli/freeze.py: 1 × UP035 (deprecated-import) - src/tmuxp/cli/load.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/cli/shell.py: 1 × UP035 (deprecated-import) - src/tmuxp/cli/utils.py: 1 × UP007 (non-pep604-annotation-union) 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/plugin.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/shell.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/workspace/finders.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - tests/cli/test_load.py: 1 × UP007 (non-pep604-annotation-union) 1 × UP035 (deprecated-import) 1 × I001 (unsorted-imports) 1 × UP045 (non-pep604-annotation-optional) Found 24 errors (20 fixed, 4 remaining). No fixes available (4 hidden fixes can be enabled with the `--unsafe-fixes` option).

This satisfies the B905 ruff check for Python 3.10+ where zip() requires an explicit strict parameter.

uv run ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes Fixed 9 errors: - docs/_ext/aafig.py: 1 × FURB103 (write-whole-file) 1 × FURB101 (read-whole-file) 1 × I001 (unsorted-imports) 1 × G004 (logging-f-string) - src/tmuxp/_internal/config_reader.py: 1 × PLW1514 (unspecified-encoding) - src/tmuxp/cli/convert.py: 1 × FURB103 (write-whole-file) - src/tmuxp/cli/freeze.py: 1 × FURB103 (write-whole-file) - src/tmuxp/cli/import_config.py: 1 × FURB103 (write-whole-file) - src/tmuxp/workspace/builder.py: 1 × G004 (logging-f-string) Found 1120 errors (9 fixed, 1111 remaining).

Ensures the typing_extensions import in test fixture _types.py is properly guarded to avoid runtime ImportError when typing_extensions is not available.

Fixes two E501 (line-too-long) errors by breaking string literals across multiple lines using implicit string concatenation: - docs/_ext/aafig.py:134 - src/tmuxp/workspace/builder.py:421 All checks now pass: ✅ ruff check: All checks passed! ✅ mypy: Success ✅ pytest: 204 passed, 3 skipped

Root cause: When we converted f-strings to %s format strings in logger.warning(), the log record behavior changed: - f-strings: record.msg contains the fully formatted string - %s format: record.msg contains the template with %s placeholders record.message contains the formatted result The test was checking record.msg which now contains the unformatted template like 'Cannot set environment for new %s.' instead of the formatted message like 'Cannot set environment for new windows.' Fix: Changed assertions to use record.message (the proper way to access formatted log messages) instead of record.msg.

tony force-pushed the drop-python-3.9 branch from c51c212 to ba4ad04 Compare November 1, 2025 15:11

tony added 13 commits November 1, 2025 10:29

ci(tests) Drop Python 3.9

774e91f

See also: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

pyproject(requires-python) 3.9 -> 3.10 minimum

fdf471e

See also: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

pyproject(trove classifiers) Drop Python 3.9

900c312

See also: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

py(deps) Bump for 3.10+ via uv sync --all-extras --dev --upgrade

399905c

pyproject(tool.ruff) Bump target-version py39 -> py310

7752e2f

See also: - https://docs.astral.sh/ruff/settings/#target-version - Python 3.9 EOL: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

pyproject(tool.mypy) Bump python_version 3.9 -> 3.10

8509b0a

See also: - https://mypy.readthedocs.io/en/stable/config_file.html#confval-python_version - Python 3.9 EOL: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

docs(README) Python minimum 3.9 -> 3.10

e511b52

See also: - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596 - https://peps.python.org/pep-0596/

docs(CHANGES) Note dropping of Python 3.9

8a3fb01

fix(B905) Add explicit strict=False to zip() calls in tests

116d74e

This satisfies the B905 ruff check for Python 3.10+ where zip() requires an explicit strict parameter.

fix(typing): Guard typing_extensions import in test fixtures

7e1ed5f

Ensures the typing_extensions import in test fixture _types.py is properly guarded to avoid runtime ImportError when typing_extensions is not available.

tony force-pushed the drop-python-3.9 branch from a4cc0f4 to fea0198 Compare November 1, 2025 15:29

tony merged commit e37b56b into master Nov 1, 2025
18 checks passed

tony deleted the drop-python-3.9 branch November 1, 2025 15:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Drop Python 3.9 #987

Drop Python 3.9 #987

Uh oh!

tony commented Nov 1, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Drop Python 3.9 #987

Drop Python 3.9 #987

Uh oh!

Conversation

tony commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Drop Python 3.9

Uh oh!

codecov bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tony commented Nov 1, 2025 •

edited

Loading

codecov bot commented Nov 1, 2025 •

edited

Loading