Skip to content

Update Capsule modalProps type #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2024
Merged

Update Capsule modalProps type #2194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c36e4dc
Update modalProps
May 14, 2024
c6e698a
chore: Update wallet label and icon in capsule function
May 17, 2024
5674aeb
chore: Update @web3-onboard/capsule dependency to version 2.0.3-alpha.2
May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"@web3-onboard/arcana-auth": "^2.0.0",
"@web3-onboard/bitget": "^2.0.0",
"@web3-onboard/blocto": "^2.0.0",
"@web3-onboard/capsule": "^2.0.2",
"@web3-onboard/capsule": "^2.0.3-alpha.2",
"@web3-onboard/cede-store": "^2.2.0",
"@web3-onboard/coinbase": "^2.2.7",
"@web3-onboard/core": "^2.21.6",
Expand Down
2 changes: 1 addition & 1 deletion docs/src/routes/docs/[...4]wallets/[...5]capsule/+page.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ type CapsuleInitOptions = {
constructorOpts?: Partial<ConstructorOpts>
appName: string
/** @optional capsule modal props */
modalProps?: Partial<CapsuleModalV2Props>
modalProps?: Partial<CapsuleModalPropsForInit>
}
```
## Usage
Expand Down
2 changes: 1 addition & 1 deletion packages/capsule/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@web3-onboard/capsule",
"version": "2.0.3-alpha.1",
"version": "2.0.3-alpha.2",
"description": "Capsule SDK wallet module for connecting to Web3-Onboard. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
"module": "dist/index.js",
"browser": "dist/index.js",
Expand Down
4 changes: 2 additions & 2 deletions packages/capsule/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ function validateOptions(
function capsule(options: CapsuleInitOptions): WalletInit {
return () => {
return {
label: 'Capsule',
getIcon: async () => (await import('./icon')).default,
label: options.walletLabel || 'Capsule',
getIcon:options.walletIcon || (async () => (await import('./icon')).default),
getInterface: async ({ chains, appMetadata }) => {
const { default: Capsule } = await import(
'@usecapsule/react-sdk'
Expand Down
7 changes: 6 additions & 1 deletion packages/capsule/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,14 @@ import type { ConstructorOpts, Environment, CapsuleModalV2Props } from '@usecaps
* @property {string} [apiKey] - API key is necessary for performing transactions and wallet creation.
* This key needs to be obtained by completing a form available at https://7f4shq8oyfd.typeform.com/to/F86oVLhb.
*/

export type CapsuleModalPropsForInit = Omit<CapsuleModalV2Props,'isOpen' | 'capsule'>;

export type CapsuleInitOptions = {
environment: Environment
apiKey: string,
constructorOpts?: Partial<ConstructorOpts>
modalProps?: Partial<CapsuleModalV2Props>
modalProps?: Partial<CapsuleModalPropsForInit>
walletIcon: () => Promise<string>
walletLabel?: string
}
2 changes: 1 addition & 1 deletion packages/demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@web3-onboard/arcana-auth": "^2.0.0",
"@web3-onboard/bitget": "2.0.1",
"@web3-onboard/blocto": "^2.0.1",
"@web3-onboard/capsule": "2.0.3-alpha.1",
"@web3-onboard/capsule": "^2.0.3-alpha.2",
"@web3-onboard/cede-store": "^2.2.0",
"@web3-onboard/core": "^2.21.6",
"@web3-onboard/coinbase": "^2.2.7",
Expand Down