Update Capsule modalProps type #2194
Conversation
Add new type that Omits `isOpen` and `capsule` keys from `CapsuleModalV2Props` inline with the wagmi v1 and v2 changes made to omit the same keys from `CapsuleModalProps`.
Introduces new label type for the CapsuleInitOptions allowing for override of the default labe/icon for client customization.
|
@Adamj1232 Made the package version changes. We also decided on making an additional prop Type change for our module. Thanks! |
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
2 participants
Add new type that Omits
isOpenandcapsulekeys fromCapsuleModalV2Propsinline with the wagmi v1 and v2 changes made to omit the same keys fromCapsuleModalProps.PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)