Feat: Update the Wallet name from bitget to Bitget Wallet #1967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Adamj1232
reviewed
Oct 24, 2023
Adamj1232
reviewed
Oct 24, 2023
Adamj1232
reviewed
Oct 24, 2023
Adamj1232
reviewed
Oct 24, 2023
| return () => { | ||
| return { | ||
| label: 'Bitget', | ||
| label: 'Bitget Wallet', |
Contributor
There was a problem hiding this comment.
This line will update the client naming of the wallet.
You can probably revert the changes to add Wallet to variable names as it will be implied
Contributor
Author
There was a problem hiding this comment.
I see. Thanks for reply
…3-onboard/bitkeep is deprecated, and the linked wallet uses @web3-onboard/bitget
Adamj1232
approved these changes
Oct 25, 2023
Contributor
Adamj1232
left a comment
Adamj1232
left a comment
There was a problem hiding this comment.
Thanks for the PR and collaboration!
Adamj1232
changed the title
This was referenced Oct 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Blocknative team,
This PR update the Wallet name from bitget to Bitget Wallet
Cheers,
bitget wallet team