Skip to content

Commit 8ddf5e6

Browse files
cole1-yangkeanAdamj1232
authored
feat:update the Wallet name from bitget to Bitget Wallet (#1967)
* feat:update the Wallet name from bitget to Bitget Wallet * feat: Modify the wallet icon format from the original base64 to svg * Update packages/bitget-wallet/package.json * Update docs/src/routes/docs/[...4]wallets/[...2]bitget/+page.md * Update docs/src/routes/docs/[...4]wallets/[...2]bitget/+page.md * Revert folder name change * Bump bitget and bitkeep package versions * feat:add a declaration and modify the bitkeep documentation that @web3-onboard/bitkeep is deprecated, and the linked wallet uses @web3-onboard/bitget * Revert removal of install and usage docs, add warning to docs and readme --------- Co-authored-by: kean <[email protected]@bitget.com> Co-authored-by: Adam Carpenter <[email protected]>
1 parent e732f61 commit 8ddf5e6

File tree

8 files changed

+36
-29
lines changed

8 files changed

+36
-29
lines changed

docs/src/routes/docs/[...4]wallets/[...3]bitkeep/+page.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ title: BitKeep
44

55
# {$frontmatter.title}
66

7+
:::admonition type=warning
8+
_Wallet module for connecting Bitkeep to web3-onboard is now deprecated due to company rebranding. Please use [@web3-onboard/bitget](../../wallets/bitget.md)_
9+
:::
10+
711
## Wallet module for connecting BitKeep Wallet through web3-onboard
812

913
BitKeep Wallet SDK wallet module for connecting to Web3-Onboard. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.

packages/bitget/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/bitget",
3-
"version": "2.0.0",
3+
"version": "2.0.1-alpha.1",
44
"description": "bitget-wallet SDK wallet module for connecting to Web3-Onboard. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",
@@ -33,7 +33,7 @@
3333
"Crypto",
3434
"Crypto Wallet",
3535
"Enkrypt",
36-
"bitgetWallet"
36+
"Bitget Wallet"
3737
],
3838
"repository": {
3939
"type": "git",
@@ -61,7 +61,7 @@
6161
"typescript": "^4.5.5"
6262
},
6363
"dependencies": {
64-
"@bitget-wallet/web3-sdk": "^0.0.6",
64+
"@bitget-wallet/web3-sdk": "^0.0.8",
6565
"@web3-onboard/common": "^2.3.3"
6666
}
6767
}

packages/bitget/src/index.ts

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
11
import type { WalletInit, EIP1193Provider } from '@web3-onboard/common'
22

3-
let bitgetDependencies: any = null
4-
let bitgetAdapter: any = null
3+
let bitgetWalletDependencies: any = null
4+
let bitgetWalletAdapter: any = null
55

6-
const loadBitgetDependencies = async (getAdapter?: boolean) => {
7-
if (!bitgetDependencies) {
8-
bitgetDependencies = await import('@bitget-wallet/web3-sdk')
6+
const loadBitgetWalletDependencies = async (getAdapter?: boolean) => {
7+
if (!bitgetWalletDependencies) {
8+
bitgetWalletDependencies = await import('@bitget-wallet/web3-sdk')
99
}
10-
if (getAdapter && !bitgetAdapter) {
11-
bitgetAdapter = new bitgetDependencies.LegacyEip1193Adapter()
12-
return bitgetAdapter
10+
if (getAdapter && !bitgetWalletAdapter) {
11+
bitgetWalletAdapter = new bitgetWalletDependencies.LegacyEip1193Adapter()
12+
return bitgetWalletAdapter
1313
}
1414
if (getAdapter) {
15-
return bitgetAdapter
15+
return bitgetWalletAdapter
1616
}
17-
return bitgetDependencies
17+
return bitgetWalletDependencies
1818
}
1919

20-
function bitget(): WalletInit {
20+
function bitgetWallet(): WalletInit {
2121
if (typeof window === 'undefined') return () => null
2222

2323
return () => {
2424
return {
25-
label: 'Bitget',
25+
label: 'Bitget Wallet',
2626
getIcon: async () => {
27-
const sdkAdapter = await loadBitgetDependencies(true)
28-
return sdkAdapter.getLogo()
27+
const { WalletInfo } = await loadBitgetWalletDependencies()
28+
return WalletInfo.logolist.svg[256];
2929
},
3030
getInterface: async () => {
3131
const {
3232
currentProvider,
3333
getIsInstall,
3434
getDownload,
3535
installWalletMessage
36-
} = await loadBitgetDependencies()
36+
} = await loadBitgetWalletDependencies()
3737

3838
let provider: EIP1193Provider
3939
if (getIsInstall()) {
@@ -48,4 +48,4 @@ function bitget(): WalletInit {
4848
}
4949
}
5050

51-
export default bitget
51+
export default bitgetWallet

packages/bitkeep/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# @web3-onboard/bitkeep
22

3+
## (Deprecated) Wallet module for connecting Bitkeep to web3-onboard
4+
_Use [@web3-onboard/bitget](https://www.npmjs.com/package/@web3-onboard/bitget)_
5+
36
## Wallet module for connecting Bitkeep Wallet through web3-onboard
47

58
Bitkeep Wallet SDK wallet module for connecting to Web3-Onboard. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.

packages/bitkeep/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/bitkeep",
3-
"version": "2.0.0",
3+
"version": "2.0.1-alpha.1",
44
"description": "Bitkeep Wallet SDK wallet module for connecting to Web3-Onboard. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",
@@ -33,7 +33,7 @@
3333
"Crypto",
3434
"Crypto Wallet",
3535
"Enkrypt",
36-
"bitkeep"
36+
"Bitget Wallet"
3737
],
3838
"repository": {
3939
"type": "git",
@@ -61,7 +61,7 @@
6161
"typescript": "^4.5.5"
6262
},
6363
"dependencies": {
64-
"@bitget-wallet/web3-sdk": "^0.0.6",
64+
"@bitget-wallet/web3-sdk": "^0.0.8",
6565
"@web3-onboard/common": "^2.3.3"
6666
}
6767
}

packages/bitkeep/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ function bitKeep(): WalletInit {
2424
return {
2525
label: 'BitKeep',
2626
getIcon: async () => {
27-
const sdkAdapter = await loadBitKeepDependencies(true)
28-
return sdkAdapter.getLogo()
27+
const { WalletInfo } = await loadBitKeepDependencies();
28+
return WalletInfo.logolist.svg[256];
2929
},
3030
getInterface: async () => {
3131
const {

packages/demo/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"@safe-global/safe-apps-provider": "^0.18.0",
2929
"@safe-global/safe-apps-sdk": "^8.1.0",
3030
"@web3-onboard/arcana-auth": "^2.0.0",
31-
"@web3-onboard/bitget": "2.0.0",
31+
"@web3-onboard/bitget": "2.0.1-alpha.1",
3232
"@web3-onboard/blocto": "2.0.0",
3333
"@web3-onboard/cede-store": "^2.1.0",
3434
"@web3-onboard/coinbase": "^2.2.6",

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -426,10 +426,10 @@
426426
"@babel/helper-validator-identifier" "^7.22.20"
427427
to-fast-properties "^2.0.0"
428428

429-
"@bitget-wallet/web3-sdk@^0.0.6":
430-
version "0.0.6"
431-
resolved "https://registry.yarnpkg.com/@bitget-wallet/web3-sdk/-/web3-sdk-0.0.6.tgz#f30f7fbdeb804ddc98b175ed977340bc856011ed"
432-
integrity sha512-UfMxJGmIAyqJBIY90nS1IrhFZvOzAvvcPt2/QhsfRQBYya8PoIwXEBofIfFeMgyVD00E7oq130DheAwFUduadA==
429+
"@bitget-wallet/web3-sdk@^0.0.8":
430+
version "0.0.8"
431+
resolved "https://registry.yarnpkg.com/@bitget-wallet/web3-sdk/-/web3-sdk-0.0.8.tgz#1510b0b379654ff0de5e10ae19bef93fa86e46c3"
432+
integrity sha512-WFk6URUxTCukKrU3YpTdWTCScrj6/wwd/0O7eSANeQl1KDbDs+yj/fAkN1Wy6ebI3NMcW6sqN9mrmfwz53dPMQ==
433433
dependencies:
434434
"@metamask/safe-event-emitter" "^3.0.0"
435435
"@solana/web3.js" "^1.78.0"

0 commit comments

Comments
 (0)