Skip to content

Conversation

@j-acks0n
Copy link
Contributor

@j-acks0n j-acks0n commented Aug 4, 2023

Description

  • Updated xdefi icon
  • Updated READM.md for out of date doc link

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@leightkt
Copy link
Contributor

leightkt commented Aug 4, 2023

@j-acks0n Please update to alpha.1 version and also update the @web3-onboard/xdefi version in docs/package.json. Thx!

"@web3-onboard/walletconnect": "^2.4.5-alpha.1",
"@web3-onboard/web3auth": "^2.2.2",
"@web3-onboard/xdefi": "^2.0.3",
"@web3-onboard/xdefi": "^2.0.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@web3-onboard/xdefi": "^2.0.5",
"@web3-onboard/xdefi": "^2.0.5-alpha.1",

@taylorjdawson
Copy link
Contributor

@j-acks0n along with @leightkt suggestion can you also merge latest develop? thanks!

@leightkt leightkt merged commit 9877d59 into thirdweb-dev:develop Aug 21, 2023
Adamj1232 added a commit that referenced this pull request Aug 29, 2023
* Add link & update nomenclature (#1881)

added link that was missing for quickstart & updated to Web3 Onboard.

* Update Trezor to 9.0.11 (#1882)

* Update Trezor to 9.0.11

Getting error:

TypeError: Cannot destructure property 'BridgeV2' of 'transport_1.default' as it is undefined.

This seems to have changed recently (within the last couple of days) as this is breaking in one of our automated tests.

Info:

@trezor/connect v9.0.7

How to reproduce
This happens consistently when trying to import the module.


Update to 9.0.11 should solve this

* Update package.json version to 2.4.3-alpha.1

---------

Co-authored-by: Kat Leight <[email protected]>

* feat: updated xdefi icon (#1870)

* feat: updated xdefi icon

* chore: package version bumps

* Update packages/xdefi/package.json

* chore: updated package.json

---------

Co-authored-by: Kat Leight <[email protected]>

* Feat/add additional required methods props to wc (#1883)

* add ability to pass additionalRequiredMethods in WalletConnectOptions

* bump minor version to alpha.1

* add documentation for additionalRequiredMethods

* bump @walletconnect/ethereum-provider to ^2.10.0

* Add to internal demo and docs, update readme

---------

Co-authored-by: Kat Leight <[email protected]>
Co-authored-by: Adam Carpenter <[email protected]>

* Bump versions and yarn, add WC instance return for session info

---------

Co-authored-by: Taylor Dawson <[email protected]>
Co-authored-by: Laurence <[email protected]>
Co-authored-by: Rohan <[email protected]>
Co-authored-by: Kat Leight <[email protected]>
Co-authored-by: Jackson Hong <[email protected]>
Co-authored-by: marc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants