Feat/add additional required methods props to wc #1883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sednaoui
force-pushed
the
feat/add-additionalRequiredMethods-props-to-wc
branch
from
c08d34e to
381a93d
Compare
Sednaoui
force-pushed
the
feat/add-additionalRequiredMethods-props-to-wc
branch
from
381a93d to
c2c0f31
Compare
Contributor
|
@Sednaoui thanks so much for the PR- I'll work on reviewing/testing first thing next week! |
Contributor
|
@Sednaoui can we also bump the |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Adamj1232
approved these changes
Aug 28, 2023
This was referenced Aug 29, 2023
Merged
Merged
Adamj1232
added a commit
that referenced
this pull request
Aug 29, 2023
* Add link & update nomenclature (#1881) added link that was missing for quickstart & updated to Web3 Onboard. * Update Trezor to 9.0.11 (#1882) * Update Trezor to 9.0.11 Getting error: TypeError: Cannot destructure property 'BridgeV2' of 'transport_1.default' as it is undefined. This seems to have changed recently (within the last couple of days) as this is breaking in one of our automated tests. Info: @trezor/connect v9.0.7 How to reproduce This happens consistently when trying to import the module. Update to 9.0.11 should solve this * Update package.json version to 2.4.3-alpha.1 --------- Co-authored-by: Kat Leight <[email protected]> * feat: updated xdefi icon (#1870) * feat: updated xdefi icon * chore: package version bumps * Update packages/xdefi/package.json * chore: updated package.json --------- Co-authored-by: Kat Leight <[email protected]> * Feat/add additional required methods props to wc (#1883) * add ability to pass additionalRequiredMethods in WalletConnectOptions * bump minor version to alpha.1 * add documentation for additionalRequiredMethods * bump @walletconnect/ethereum-provider to ^2.10.0 * Add to internal demo and docs, update readme --------- Co-authored-by: Kat Leight <[email protected]> Co-authored-by: Adam Carpenter <[email protected]> * Bump versions and yarn, add WC instance return for session info --------- Co-authored-by: Taylor Dawson <[email protected]> Co-authored-by: Laurence <[email protected]> Co-authored-by: Rohan <[email protected]> Co-authored-by: Kat Leight <[email protected]> Co-authored-by: Jackson Hong <[email protected]> Co-authored-by: marc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to pass required methods for walletconnect options
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/no applicable