[core] Fix- Stop modal pop up when switching to already connected wallet #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd update packages
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lnbc1QWFyb24
approved these changes
Mar 16, 2023
Adamj1232
reviewed
Mar 16, 2023
| "dependencies": { | ||
| "@web3-onboard/ledger": "^2.1.6", | ||
| "@web3-onboard/react": "^2.4.1", | ||
| "@web3-onboard/react": "^2.6.7-alpha.2", |
Contributor
There was a problem hiding this comment.
Just an FYI we have come across - if using the example packages for testing prior to an alpha version being published they may return a false positive as yarn workspaces doesn't behave the same as a published package
Adamj1232
approved these changes
Mar 16, 2023
Contributor
Adamj1232
left a comment
Adamj1232
left a comment
There was a problem hiding this comment.
Looks good, nice work!! I would prob get this one merged before the other as this one seems lower impact 🔥
This was referenced Mar 24, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: #888
Stops calling selectAccounts when switching to an already connected wallet- stops displaying pop up that says "Please switch the active account in your wallet."
Testing Video
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)