[Bug]: selectAccounts(existingWallet.provider) always throws error

[danpetban]

Current Behavior

selectAccounts(existingWallet.provider) always throws errors, because the provider implementations.

As I can see, all of it just implement the following:
eth_selectAccounts: UNSUPPORTED_METHOD

According to this, the actionRequired value will be true and the modal appears.

Expected Behavior

Just because the provider does not have a eth_selectAccounts method, don't show the modal every time.

Steps To Reproduce

No response

Onboard Version

core: 2.0.11, injected: 2.0.2

Node Version

16

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Anything else?

No response

[lnbc1QWFyb24]

Hey @band94, the idea with that modal is that when the user selects a wallet that they are already connected to, then their intention is to connect another account for that wallet. In the case of hardware wallets, we have control of the UI, so we can show the user the account select options. That is what we created the eth_selectAccounts RPC method for. In the case of other wallets that we do not have control of the UI, then that method is not implemented (since we made it up), so in that case we display the modal to guide the user to connecting another account.

Are you trying to call the eth_selectAccounts method directly?

[lnbc1QWFyb24]

Going to close this for now as that is expected behavior. Feel free to reopen if you have further questions.

[Holybasil]

@aaronbarnardsound Thanks for your explanation, pretty helpful 🎉

[MojoDeMedici]

@aaronbarnardsound This makes sense if you look at it as you did. However this becomes an annoying issue if you are trying to reconnect a wallet that you stored in the localstorage for example.
In my case I was trying to "persist" a wallet connection after a page refresh, and in discord someone of the team suggested to look at the implementation of Auto Selecting a Wallet in the core documentation.
Following the example I was able to set a localstorage look up and so automatically persist the wallet connection despite the browser page refresh (this is great because makes a better ux, removing the need to re-click on the connecting button after refresh).
I was very happy with the solution until I discovered that if something gets updated reactively, then the solution triggers the popup and Action Required.
This clearly in my case is pointless, because there isn't any switch of wallet. How I solve or disable this?

I am using the VUE plugin, and my code is something like the following:

const walletInitializer = async () => {
    const previouslyConnectedWallets = JSON.parse(
      window.localStorage.getItem('alreadyConnectedWallets')
    )
    if (previouslyConnectedWallets[0]) {
      try {
        await connectWallet({
          autoSelect: {
            label: previouslyConnectedWallets[0],
            disableModals: true,
          },
        })
      } catch (error) {
        console.log('Houston we got a problem!', error.error)
      }
    }
  }

[lnbc1QWFyb24]

Hey @Dinuz could you elaborate on what is getting updated reactively that triggers that modal? Could you try connecting a wallet and then refreshing on our React Demo and see if you see the same behaviour? We don't have the disableModals flag set in the demo, but I just tried locally with that flag set and everything works as expected.

[MojoDeMedici]

@aaronbarnardsound yeah I should clarify that this problematic behavior is more appropriate to be described as appearing during HOT RELOAD than during pure RESPONSIVENESS RESPONSE (I am using vite and vue).

In my frontend I do have a way to setup an options array that goes directly into the composable in which I have the previous function (the one in my previous post walletInitializer) defined. The options are used to control the composable behavior (for example I can change the min balance required in order for the user to be able to perform some operations eg mint). Every time that I change one of these options (hot reload kicks in) I do have the popup coming out with the following message:

I found a way to kill this but I am not sure it is the most beautiful and appropriate way to do so: I call the disconnect wallet just before connecting it again (to be truly honest I don't like this at all, but it removes the error and prevents the popup to showing up). So If I modify the previous function in the following way, my problem gets solved:

const walletInitializer = async () => {
    const previouslyConnectedWallets = JSON.parse(
      window.localStorage.getItem('alreadyConnectedWallets')
    )

    if (previouslyConnectedWallets[0]) {
      try {
        await disconnectWallet({ label: previouslyConnectedWallets[0] }) // I ADD THIS NEW LINE
        await connectWallet({
          autoSelect: {
            label: previouslyConnectedWallets[0],
            disableModals: true,
          },
        })
      } catch (error) {
        console.log('Cannot initialize the wallet!', error.error)
      }
    }
  }

What do you think? Suggestions? Opinions? Yelling at me lol?

Thanks :)

PS. Side note, probably the icon and the circle around the icon, and the whole button should be designed explicitly using dedicated css variables so people would be able to fully customize the popup.

[katspaugh]

As others mentioned here, this popup appears even when you don't want to select another account but rather another wallet.

Consider this use case:

• User is connected to an app with MetaMask
• They then decide to switch to their mobile wallet via WalletConnect
• Potentially switch back to the first wallet

In this case, we would call connectWallet() w/o specifying a wallet, so that the user can choose one.

And then this annoying popup appears, which actually does nothing. And an error in the console.

Do you think we could avoid showing this popup unless the app explicitly asks to switch the account within the same wallet?

[lnbc1QWFyb24]

We'll be taking another look at this issue as we have had multiple reports of this.

[jamesmorgan]

Also seeing this issue - vue/nuxt