Skip to content

Added all platform support for injected Trust Wallet #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Added all platform support for injected Trust Wallet #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9b873be
fix: Change Trust Wallet in wallets.ts platform param to 'all' now th…
Nov 8, 2022
618be6f
fix: Change Trust Wallet in wallets.ts platform param to 'all' now th…
Nov 8, 2022
116e4c4
Update packages/injected/package.json
chaoticgoodpanda Nov 10, 2022
3ef75f3
fix: Remove extraneous dev deps from package.json.
Nov 10, 2022
588f641
Merge branch 'v2-web3-onboard-develop' of github.com:chaoticgoodpanda…
Nov 10, 2022
9765e88
Update packages/injected/package.json
Adamj1232 Nov 10, 2022
cbed2e4
Update
Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/injected/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export const WALLET_NAMES: { [key: string]: string } = {
binance: 'Binance Chain Wallet',
bitpie: 'Bitpie',
bitski: 'Bitski',
trust: 'Trust Wallet',
coinbasewallet: 'Coinbase Wallet',
dcentwallet: "D'CENT",
metamask: 'MetaMask',
Expand Down
2 changes: 1 addition & 1 deletion packages/injected/src/wallets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ const trust: InjectedWalletModule = {
eth_selectAccounts: UNSUPPORTED_METHOD
})
}),
platforms: ['mobile']
platforms: ['all']
Copy link
Contributor

@Adamj1232 Adamj1232 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only change that occurred with the desktop wallet provider?

Copy link
Author

@chaoticgoodpanda chaoticgoodpanda Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's it. Assumption is that's all that's needed to support our new browser extension: https://chrome.google.com/webstore/detail/trust-wallet/egjidjbpglichdcondbcbdnbeeppgdph

Copy link
Contributor

@Adamj1232 Adamj1232 Nov 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaoticgoodpanda great, have you tested with the internal demo project(packages/demo) to verify W3O is working properly with changing of chains, signing, sending transaction, etc?
Running yarn && yarn dev will get it going

}

const opera: InjectedWalletModule = {
Expand Down