Added all platform support for injected Trust Wallet #1357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 8, 2022 18:20
…at there is a Trust Wallet browser extension.
…at there is a Trust Wallet browser extension.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Adamj1232
reviewed
Nov 9, 2022
Adamj1232
reviewed
Nov 9, 2022
Adamj1232
reviewed
Nov 9, 2022
| }) | ||
| }), | ||
| platforms: ['mobile'] | ||
| platforms: ['all'] |
There was a problem hiding this comment.
Is this the only change that occurred with the desktop wallet provider?
There was a problem hiding this comment.
Yes, that's it. Assumption is that's all that's needed to support our new browser extension: https://chrome.google.com/webstore/detail/trust-wallet/egjidjbpglichdcondbcbdnbeeppgdph
There was a problem hiding this comment.
@chaoticgoodpanda great, have you tested with the internal demo project(packages/demo) to verify W3O is working properly with changing of chains, signing, sending transaction, etc?
Running yarn && yarn dev will get it going
Adamj1232
suggested changes
Nov 9, 2022
Co-authored-by: Adam Carpenter <[email protected]>
added 2 commits
November 10, 2022 16:29
…/web3-onboard into v2-web3-onboard-develop
Adamj1232
reviewed
Nov 10, 2022
|
Closing in favor of #1463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at there is a Trust Wallet browser extension.
Description
I'm on the Trust team, and we have a Chrome browser extension released: https://chrome.google.com/webstore/detail/trust-wallet/egjidjbpglichdcondbcbdnbeeppgdph. Changing the platform param for Trust's injected wallet in Blocknative to be 'all' instead of 'mobile' so TW extension can be connected via blocknative-powered dApps.
Checklist
package.jsonis incremented following semantic versioningyarn check&yarn buildto confirm there are not any associated errors