Feature/hide sidebar

[DisruptiveMind]

Description

adds hideSidebar option to appMetadata to hide the branding sidebar.

Checklist

• The version field in package.json is incremented following semantic versioning
• The box that allows repo maintainers to update this PR is checked
• I tested locally to make sure this feature/fix works
• I have run yarn type-check & yarn build to confirm there are not any associated errors
• This PR passes the Circle CI checks

[gesquinca]

Hey @DisruptiveMind, I'm curious as to what is the main goal of this feature. Could you tell me a little more about what you're trying to accomplish in your project?

[DisruptiveMind]

hey @gesquinca thanks for checking this out. The goal is simply to remove branding.
The hideBranding feature was available in bnc-onboard v1 and I would be using this on a single app with multiple branding and wanted to simplify the wallet modal.

[Adamj1232]

@DisruptiveMind thank you for the PR! We are going to approach this a little differently by adding a new config option as appMetaData doesn't feel correct and we have more configurations coming down the line. We will start work on this shortly and notify you here when we have a solution in PR

[Adamj1232]

@DisruptiveMind are you wanting to hide the sidebar completely or would hiding the Blocknative branding and leaving the sidebar suite your needs? Both are totally doable but trying to understand your request fully.

[DisruptiveMind]

hey, @Adamj1232 the goal would be to hide the sidebar completely with something like hideSidebar or hideBranding.

It would be nice to have a slot for full control of branding if possible as another option, but my use case would just be to hide the sidebar completely.

[Adamj1232]

@DisruptiveMind thanks for the feedback! I merged #1191 this morning which is similar to the approach you took but with a new init object and props to allow for expansion of the options and better state management. I will close this PR in favor of the latest merge. You can check it out by using the Alpha packages - core - 2.7.0-alpha.1 or react - 2.2.6-alpha.1
#1191