[core-v2.7.0-alpha.1, react-v2.2.6-alpha.1, vue-v2.1.6-alpha.1] : Feature - Add configuration to hide/show sidebar #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamj1232
requested review from
lnbc1QWFyb24,
mahmud-bn and
taylorjdawson
and removed request for
lnbc1QWFyb24 and
taylorjdawson
Adamj1232
changed the title
lnbc1QWFyb24
approved these changes
Aug 3, 2022
Contributor
lnbc1QWFyb24
left a comment
lnbc1QWFyb24
left a comment
There was a problem hiding this comment.
Just a couple of suggestions, but nothing crucial to the PR.
Co-authored-by: Aaron <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to add a configuration to hide the Connect Modal side bar.
The changes adds a
connectproperty on the AppState and init options with an internal prop ofshowSidebar : booleanthat defaults totrueChecklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors